Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group_by_job option inspect_state #232

Merged
merged 19 commits into from
Jan 18, 2024
Merged

Conversation

burnout87
Copy link
Collaborator

No description provided.

@burnout87 burnout87 linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d56ad3a) 57.56% compared to head (5de1a51) 58.21%.

Files Patch % Lines
oda_api/cli.py 75.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   57.56%   58.21%   +0.64%     
==========================================
  Files          23       23              
  Lines        4781     4829      +48     
==========================================
+ Hits         2752     2811      +59     
+ Misses       2029     2018      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burnout87
Copy link
Collaborator Author

burnout87 commented Jan 9, 2024

the error:

E ModuleNotFoundError: No module named 'importlib.metadata'

comes from in incompatibility of python 3.7 and the library importlib-metadata at the version required by several dependencies. And the one raising the error is astropy flask_restx, others have the same issue here

https://github.com/newville/asteval/issues/93

@okolo

EDIT bug is here python-restx/flask-restx#586

And as the devs there suggest, python 3.7, will no longer be supported (to be precise, all python <= 3.8)

This fix works, but it may break again in the future

oda_api/cli.py Outdated Show resolved Hide resolved
oda_api/cli.py Outdated Show resolved Hide resolved
@burnout87
Copy link
Collaborator Author

oda-hub/dispatcher-app#642 will be needed

@burnout87 burnout87 marked this pull request as ready for review January 17, 2024 11:22
@burnout87
Copy link
Collaborator Author

I still cannot merge on this repo. Can you please re-assign me the rights for that @volodymyrss ?

@volodymyrss
Copy link
Member

now?

@burnout87 burnout87 merged commit b0b57ea into master Jan 18, 2024
15 checks passed
@burnout87
Copy link
Collaborator Author

now?

yes, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend inspect_state CLI with job inspection
2 participants